[Branch-2.8][improve][broker]Add retry for zk operation on connection loss #17226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
added
type/enhancement
zymap
reviewed
Aug 23, 2022
| future.complete(Optional.empty()); | ||
| } else { | ||
| } else if (code == Code.CONNECTIONLOSS) { | ||
| // There is the chance that we caused a connection reset by sending or requesting a batch |
Member
There was a problem hiding this comment.
Do we need to log something before retrying?
Jason918
reviewed
Aug 23, 2022
| } else if (code == Code.CONNECTIONLOSS) { | ||
| // There is the chance that we caused a connection reset by sending or requesting a batch | ||
| // that passed the max ZK limit. Retry with the individual operations | ||
| executor.schedule(() -> getChildrenFromStore(path), |
Contributor
There was a problem hiding this comment.
We need pass the result of getChildrenFromStore to future in this.
Contributor
Author
There was a problem hiding this comment.
Good point, addressed.
Jason918
approved these changes
Aug 23, 2022
codelipenghui
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the master branch, we have supported zk retry logic for connection loss cases, which will reduce data inconsistency for Pulsar broker with Zookeeper.
pulsar/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java
Lines 163 to 169 in 423ab75
Modification
We backport this feature into branch-2.8