Skip to content

[fix][tests] Some unit tests are not run by the CI#17767

Merged
codelipenghui merged 2 commits intoapache:masterfrom
nicoloboschi:add-ci-tests
Sep 22, 2022
Merged

[fix][tests] Some unit tests are not run by the CI#17767
codelipenghui merged 2 commits intoapache:masterfrom
nicoloboschi:add-ci-tests

Conversation

@nicoloboschi
Copy link
Contributor

Motivation

Using this command find . ! -name '*Test*' -name "*.java" -exec grep -H "@Test" {} \; I found out that some tests are not running in the CI because they don't match the surefire class name pattern

Modifications

  • Rename those tests adding the "Test" suffix
  • doc-not-needed

@tisonkun
Copy link
Member

tisonkun commented Sep 21, 2022

@nicoloboschi perhaps we need a precommit or lightweight workflow runs to prevent regressions?

Well. This script can produce false positive. And some false negative like TokenAuthWithPublicPrivateKeys.

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants