[fix][tests] Some unit tests are not run by the CI#17767
Merged
codelipenghui merged 2 commits intoapache:masterfrom Sep 22, 2022
Merged
[fix][tests] Some unit tests are not run by the CI#17767codelipenghui merged 2 commits intoapache:masterfrom
codelipenghui merged 2 commits intoapache:masterfrom
Conversation
Member
|
@nicoloboschi perhaps we need a precommit or lightweight workflow runs to prevent regressions? Well. This script can produce false positive. And some false negative like |
tisonkun
approved these changes
Sep 21, 2022
RobertIndie
approved these changes
Sep 21, 2022
9cfdd9f to
329f188
Compare
codelipenghui
approved these changes
Sep 22, 2022
4 tasks
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Using this command
find . ! -name '*Test*' -name "*.java" -exec grep -H "@Test" {} \;I found out that some tests are not running in the CI because they don't match the surefire class name patternModifications
doc-not-needed