You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The pulsar-perf-tool should be able to take "proxyServiceUrl" and "proxyProtocol" as an input arguments as it can be provided by the user.
Modifications
Add "proxyServiceUrl" and "proxyProtocol" into PerformanceBaseArguments.java class.
Make changes into PerfClientUtils.java to pass "proxyServiceUrl" and "proxyProtocol" to clientBuilder.
Add unit test cases to verify
Verifying this change
This change added tests and can be verified as follows:
-Added unit test to verify functionality
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): ( no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required
(Your PR needs to update docs and you will update later)
2022-10-04T09:45:26.7691133Z stdout: Incorrect proxyProtocol name
2022-10-04T09:45:26.7691325Z
2022-10-04T09:45:26.7691613Z stderr: java.lang.IllegalArgumentException: No enum constant org.apache.pulsar.client.api.ProxyProtocol.
2022-10-04T09:45:26.7692069Z at java.base/java.lang.Enum.valueOf(Enum.java:273)
2022-10-04T09:45:26.7692493Z at org.apache.pulsar.client.api.ProxyProtocol.valueOf(ProxyProtocol.java:28)
2022-10-04T09:45:26.7693177Z at org.apache.pulsar.testclient.PerformanceBaseArguments.fillArgumentsFromProperties(PerformanceBaseArguments.java:153)
2022-10-04T09:45:26.7693864Z at org.apache.pulsar.testclient.PerformanceProducer.main(PerformanceProducer.java:310)
2022-10-04T09:45:26.7691133Z stdout: Incorrect proxyProtocol name
2022-10-04T09:45:26.7691325Z
2022-10-04T09:45:26.7691613Z stderr: java.lang.IllegalArgumentException: No enum constant org.apache.pulsar.client.api.ProxyProtocol.
2022-10-04T09:45:26.7692069Z at java.base/java.lang.Enum.valueOf(Enum.java:273)
2022-10-04T09:45:26.7692493Z at org.apache.pulsar.client.api.ProxyProtocol.valueOf(ProxyProtocol.java:28)
2022-10-04T09:45:26.7693177Z at org.apache.pulsar.testclient.PerformanceBaseArguments.fillArgumentsFromProperties(PerformanceBaseArguments.java:153)
2022-10-04T09:45:26.7693864Z at org.apache.pulsar.testclient.PerformanceProducer.main(PerformanceProducer.java:310)
fixed by #17930 . I also created #17932 as a follow-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The pulsar-perf-tool should be able to take "proxyServiceUrl" and "proxyProtocol" as an input arguments as it can be provided by the user.
Modifications
Add "proxyServiceUrl" and "proxyProtocol" into PerformanceBaseArguments.java class.
Make changes into PerfClientUtils.java to pass "proxyServiceUrl" and "proxyProtocol" to clientBuilder.
Add unit test cases to verify
Verifying this change
This change added tests and can be verified as follows:
-Added unit test to verify functionality
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
ready-to-test