Skip to content

[clean][pom]remove unused scala-library.version from pom.xml #17954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 1 commit into from
Oct 10, 2022
Merged

[clean][pom]remove unused scala-library.version from pom.xml #17954

codelipenghui merged 1 commit into from
Oct 10, 2022

Conversation

@Pomelongan
Copy link
Contributor

@Pomelongan Pomelongan commented Oct 6, 2022

Motivation

scala-library.version in pom.xml is no longer used.

Modifications

remove unused scala-library.version from pom.xml

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: Pomelongan#6

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 6, 2022
@HQebupt
Copy link
Contributor

HQebupt commented Oct 8, 2022 •
edited
Loading

Please rebase the latest code to resolve some test failures.

@eolivelli
Copy link
Contributor

eolivelli commented Oct 9, 2022

/pulsar-bot rerun-failure-checks

@AnonHxy
Copy link
Contributor

AnonHxy commented Oct 10, 2022

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added this to the 2.12.0 milestone Oct 10, 2022
@codelipenghui codelipenghui added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use dependencies Pull requests that update a dependency file labels Oct 10, 2022
@codelipenghui codelipenghui merged commit 5690b25 into apache:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jason918 Jason918 Jason918 approved these changes

@HQebupt HQebupt HQebupt approved these changes

@eolivelli eolivelli eolivelli approved these changes

@AnonHxy AnonHxy AnonHxy approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@hezhangjian hezhangjian hezhangjian approved these changes

Assignees

@Pomelongan Pomelongan

Labels

dependencies Pull requests that update a dependency file doc-not-needed Your PR changes do not impact docs ready-to-test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Pomelongan @HQebupt @eolivelli @AnonHxy @Jason918 @codelipenghui @hezhangjian