Skip to content

[fix][doc] fix many anchor errors#18109

Merged
Anonymitaet merged 1 commit intoapache:masterfrom
labuladong:fix-md
Oct 25, 2022
Merged

[fix][doc] fix many anchor errors#18109
Anonymitaet merged 1 commit intoapache:masterfrom
labuladong:fix-md

Conversation

@labuladong
Copy link
Contributor

@labuladong labuladong commented Oct 19, 2022 •
edited
Loading

Master Issue: #18026

Modifications

According to #18026 (comment), this pr fixes many markdown anchor errors.

For the link checker script and more errors see #18026

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: labuladong#3

@labuladong labuladong mentioned this pull request Oct 19, 2022
Closed
2 tasks
RobertIndie
RobertIndie reviewed Oct 19, 2022
View reviewed changes
Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the reference to reference-cli-tools.md, it's better to give the specific reference page for the user. Otherwise, it will confuse users. Here I give 2 examples.

@Anonymitaet
Copy link
Member

Anonymitaet commented Oct 19, 2022

For the reference to reference-cli-tools.md, it's better to give the specific reference page for the user. Otherwise, it will confuse users. Here I give 2 examples.

Generic links are preferred to reduce maintenance cost
Details see #18101 (comment)

@Anonymitaet Anonymitaet requested a review from momo-jun October 19, 2022 09:07
@Anonymitaet
Copy link
Member

Anonymitaet commented Oct 19, 2022

@labuladong .md doc PR does not need this
image

because:

pulsar/.github/changes-filter.yaml

Line 9 in 912f344

- '*.md'

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Oct 19, 2022
momo-jun
momo-jun approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@momo-jun momo-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@Anonymitaet Anonymitaet added this to the 2.11.0 milestone Oct 20, 2022
@labuladong
Copy link
Contributor Author

labuladong commented Oct 21, 2022

/pulsarbot rerun-failure-checks

@labuladong
Copy link
Contributor Author

labuladong commented Oct 21, 2022

@Anonymitaet @momo-jun Can you merge this pr? Thanks.

@Anonymitaet
Copy link
Member

Anonymitaet commented Oct 21, 2022

@labuladong This PR can not be merged because of the failed tests. Feel free to ping me if all tests pass.

@tisonkun
Copy link
Member

tisonkun commented Oct 24, 2022

@Anonymitaet I think now this PR is ready to merge.

@Anonymitaet Anonymitaet merged commit 91562d2 into apache:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobertIndie RobertIndie RobertIndie approved these changes

@Anonymitaet Anonymitaet Anonymitaet approved these changes

@momo-jun momo-jun momo-jun approved these changes

Assignees

No one assigned

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

5 participants

@labuladong @Anonymitaet @tisonkun @RobertIndie @momo-jun