[feat][sql] Support metadata store url#18210
Merged
Jason918 merged 6 commits intoapache:masterfrom Nov 2, 2022
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
debug-pulsar-sql-support-metadata
branch
from
41db6cd to
1badf26
Compare
codelipenghui
approved these changes
Nov 1, 2022
Contributor
|
/pulsarbot run-failure-checks |
2 similar comments
Contributor
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #18210 +/- ##
=============================================
+ Coverage 34.91% 45.00% +10.09%
- Complexity 5707 15916 +10209
=============================================
Files 607 1365 +758
Lines 53396 118683 +65287
Branches 5712 12883 +7171
=============================================
+ Hits 18644 53418 +34774
- Misses 32119 59846 +27727
- Partials 2633 5419 +2786
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
cc @Jason918 @codelipenghui I think this patch is ready for merge now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refers to #18209 and part of the commits is included in #18207.
Although it seems hard to integrate with the RocksDB metadata store backend which is the original purpose for this patch as described in #18209, this patch migrates Pulsar SQL dependency of metadata store to the PIP-45 proposed model. And now we can use etcd metadata store backend at least and reduce dependencies to legacy logics.
cc @merlimat @gaoran10 @nicoloboschi @Jason918 @lhotari
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: tisonkun#12