[improve][doc] Update links to the contribute guide#18509
Merged
tisonkun merged 2 commits intoapache:masterfrom Nov 17, 2022
Merged
[improve][doc] Update links to the contribute guide#18509tisonkun merged 2 commits intoapache:masterfrom
tisonkun merged 2 commits intoapache:masterfrom
Conversation
Signed-off-by: tison <wander4096@gmail.com>
github-actions
bot
added
the
doc
tisonkun
commented
Nov 16, 2022
| @@ -221,134 +219,20 @@ docker push ${image_repo_and_project}/pulsar:$tag | |||
|
|
|||
| ## Setting up your IDE | |||
Member
Author
There was a problem hiding this comment.
I agree that it helps if we inline this info but it's too long to keep in sync.
momo-jun
reviewed
Nov 17, 2022
momo-jun
reviewed
Nov 17, 2022
momo-jun
approved these changes
Nov 17, 2022
Contributor
momo-jun
left a comment
momo-jun
left a comment
There was a problem hiding this comment.
LGTM. Only left a couple of minor suggestions.
Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com>
Member
Author
|
@momo-jun Thanks! Comments addressed. |
Member
Author
|
Merging... Review after merge is welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This reflects apache/pulsar-site#295.
Documentation
docdoc-requireddoc-not-neededdoc-complete