Skip to content

Comments

[fix][broker] Revert "[fix][load-balancer] skip mis-configured resource usage(>100%) in load balancer#18645

Merged
Technoboy- merged 2 commits intoapache:masterfrom
Technoboy-:revert-16937
Nov 28, 2022
Merged

[fix][broker] Revert "[fix][load-balancer] skip mis-configured resource usage(>100%) in load balancer#18645
Technoboy- merged 2 commits intoapache:masterfrom
Technoboy-:revert-16937

Conversation

@Technoboy-
Copy link
Contributor

Motivation

Discuss is #18598

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Technoboy- Technoboy- self-assigned this Nov 27, 2022
@Technoboy- Technoboy- added this to the 2.12.0 milestone Nov 27, 2022
@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Nov 27, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 27, 2022
@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@mattisonchao
Copy link
Member

Error:  COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/pulsar/pulsar/pulsar-common/src/test/java/org/apache/pulsar/policies/data/loadbalancer/LocalBrokerDataTest.java:[61,21] cannot find symbol
  symbol:   method getMaxResourceUsageWithWeightWithinLimit(double,double,double,double,double)
  location: variable data of type org.apache.pulsar.policies.data.loadbalancer.LocalBrokerData

Please take a look at this problem.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2022

Codecov Report

Merging #18645 (55203aa) into master (b579bb8) will decrease coverage by 0.46%.
The diff coverage is 36.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18645      +/-   ##
============================================
- Coverage     47.51%   47.05%   -0.47%     
+ Complexity    10520    10416     -104     
============================================
  Files           698      698              
  Lines         68079    68056      -23     
  Branches       7280     7275       -5     
============================================
- Hits          32351    32021     -330     
- Misses        32151    32444     +293     
- Partials       3577     3591      +14     
Flag Coverage Δ
unittests 47.05% <36.36%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...loadbalance/impl/LeastResourceUsageWithWeight.java 0.00% <0.00%> (ø)
...lsar/broker/loadbalance/impl/ThresholdShedder.java 30.32% <28.57%> (-17.39%) ⬇️
...roker/loadbalance/impl/ModularLoadManagerImpl.java 63.42% <66.66%> (-5.81%) ⬇️
...ar/broker/loadbalance/impl/BundleSplitterTask.java 60.00% <0.00%> (-17.78%) ⬇️
.../pulsar/broker/service/SharedConsumerAssignor.java 61.11% <0.00%> (-16.67%) ⬇️
.../apache/pulsar/broker/admin/impl/PackagesBase.java 54.12% <0.00%> (-13.77%) ⬇️
...e/pulsar/broker/service/EntryBatchIndexesAcks.java 82.14% <0.00%> (-10.72%) ⬇️
...er/loadbalance/impl/ModularLoadManagerWrapper.java 78.04% <0.00%> (-7.32%) ⬇️
...ava/org/apache/pulsar/broker/service/Consumer.java 64.59% <0.00%> (-7.30%) ⬇️
... and 42 more

@Technoboy-
Copy link
Contributor Author

Error:  COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/pulsar/pulsar/pulsar-common/src/test/java/org/apache/pulsar/policies/data/loadbalancer/LocalBrokerDataTest.java:[61,21] cannot find symbol
  symbol:   method getMaxResourceUsageWithWeightWithinLimit(double,double,double,double,double)
  location: variable data of type org.apache.pulsar.policies.data.loadbalancer.LocalBrokerData

Please take a look at this problem.

Fixed.

@Technoboy-
Copy link
Contributor Author

@heesung-sn Could you please help review this ?

@Technoboy- Technoboy- added the release/blocker Indicate the PR or issue that should block the release until it gets resolved label Nov 28, 2022
@Technoboy- Technoboy- requested a review from hangc0276 November 28, 2022 05:56
@Technoboy- Technoboy- merged commit 363d1a9 into apache:master Nov 28, 2022
Technoboy- added a commit that referenced this pull request Nov 28, 2022
@hangc0276
Copy link
Contributor

LGTM

lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Dec 9, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
@Technoboy- Technoboy- deleted the revert-16937 branch September 14, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/branch-2.10 cherry-picked/branch-2.11 doc-not-needed Your PR changes do not impact docs ready-to-test release/blocker Indicate the PR or issue that should block the release until it gets resolved release/2.10.3 release/2.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants