Skip to content

Comments

[improve][build] Set correct project.build.outputTimestamp#18820

Merged
tisonkun merged 5 commits intoapache:masterfrom
tisonkun:omit-project.build.outputTimestamp
Dec 9, 2022
Merged

[improve][build] Set correct project.build.outputTimestamp#18820
tisonkun merged 5 commits intoapache:masterfrom
tisonkun:omit-project.build.outputTimestamp

Conversation

@tisonkun
Copy link
Member

@tisonkun tisonkun commented Dec 8, 2022

This closes #17754.

Motivation

See #17754 (comment).

Also, this corrects the generated NOTICE year range.

Modifications

  • Set project.build.outputTimestamp to maven.build.timestamp
  • Upgrade plugin for reproducible builds, spotted by mvn artifact:check-buildplan

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: tisonkun#21

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Member Author

tisonkun commented Dec 9, 2022

/pulsarbot run-failure-checks

@tisonkun
Copy link
Member Author

tisonkun commented Dec 9, 2022

After a discussion with @michaeljmarshall, we agree on continuing #17754 :)

@tisonkun tisonkun closed this Dec 9, 2022
@michaeljmarshall
Copy link
Member

@tisonkun - I'm sorry, I misread your initial PR. Your solution is better than mine. I think we should reopen this and use it.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Merging #18820 (dc12312) into master (b36e012) will increase coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18820      +/-   ##
============================================
+ Coverage     47.74%   48.47%   +0.73%     
- Complexity    10623    11385     +762     
============================================
  Files           703      763      +60     
  Lines         68828    73643    +4815     
  Branches       7381     7924     +543     
============================================
+ Hits          32861    35702    +2841     
- Misses        32307    34092    +1785     
- Partials       3660     3849     +189     
Flag Coverage Δ
unittests 48.47% <ø> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pache/pulsar/broker/tools/GenerateDocsCommand.java 0.00% <0.00%> (-77.28%) ⬇️
.../apache/pulsar/utils/CmdGenerateDocumentation.java 0.00% <0.00%> (-76.93%) ⬇️
...ava/org/apache/pulsar/broker/tools/BrokerTool.java 0.00% <0.00%> (-71.43%) ⬇️
...ulsar/utils/ConcurrentBitmapSortedLongPairSet.java 59.25% <0.00%> (-31.49%) ⬇️
...ava/org/apache/pulsar/utils/StatsOutputStream.java 70.90% <0.00%> (-29.10%) ⬇️
...pache/pulsar/utils/auth/tokens/TokensCliUtils.java 0.00% <0.00%> (-26.39%) ⬇️
.../apache/pulsar/broker/tools/LoadReportCommand.java 0.00% <0.00%> (-18.61%) ⬇️
...g/apache/bookkeeper/mledger/util/StatsBuckets.java 43.75% <0.00%> (-16.67%) ⬇️
...ar/broker/transaction/util/LogIndexLagBackoff.java 57.14% <0.00%> (-14.29%) ⬇️
...ookkeeper/mledger/impl/ManagedLedgerMBeanImpl.java 53.17% <0.00%> (-9.53%) ⬇️
... and 168 more

@tisonkun
Copy link
Member Author

tisonkun commented Dec 9, 2022

@michaeljmarshall Thanks for your review!

Merging...

@tisonkun tisonkun merged commit d30e86c into apache:master Dec 9, 2022
@tisonkun tisonkun deleted the omit-project.build.outputTimestamp branch December 9, 2022 07:58
Demogorgon314 pushed a commit to Demogorgon314/pulsar that referenced this pull request Dec 26, 2022
Demogorgon314 pushed a commit to Demogorgon314/pulsar that referenced this pull request Dec 29, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants