[improve][build] Set correct project.build.outputTimestamp#18820
Merged
tisonkun merged 5 commits intoapache:masterfrom Dec 9, 2022
Merged
[improve][build] Set correct project.build.outputTimestamp#18820tisonkun merged 5 commits intoapache:masterfrom
tisonkun merged 5 commits intoapache:masterfrom
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
After a discussion with @michaeljmarshall, we agree on continuing #17754 :) |
Member
|
@tisonkun - I'm sorry, I misread your initial PR. Your solution is better than mine. I think we should reopen this and use it. |
michaeljmarshall
approved these changes
Dec 9, 2022
1 task
Codecov Report
@@ Coverage Diff @@
## master #18820 +/- ##
============================================
+ Coverage 47.74% 48.47% +0.73%
- Complexity 10623 11385 +762
============================================
Files 703 763 +60
Lines 68828 73643 +4815
Branches 7381 7924 +543
============================================
+ Hits 32861 35702 +2841
- Misses 32307 34092 +1785
- Partials 3660 3849 +189
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
@michaeljmarshall Thanks for your review! Merging... |
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 26, 2022
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 29, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #17754.
Motivation
See #17754 (comment).
Also, this corrects the generated NOTICE year range.
Modifications
project.build.outputTimestamptomaven.build.timestampmvn artifact:check-buildplanDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: tisonkun#21