Skip to content

[cleanup][io] Remove useless kafka server dep in debezium sources#18956

Merged
nicoloboschi merged 3 commits intoapache:masterfrom
nicoloboschi:drop-kafka
Dec 16, 2022
Merged

[cleanup][io] Remove useless kafka server dep in debezium sources#18956
nicoloboschi merged 3 commits intoapache:masterfrom
nicoloboschi:drop-kafka

Conversation

@nicoloboschi
Copy link
Contributor

@nicoloboschi nicoloboschi commented Dec 16, 2022

Motivation

Pulsar IO debezium sources depends on kafka (the whole server) but it only actually needs kafka-connect framework.

Modifications

  • Removed kafka dependency from debezium-core and all the related dependencies (scala)

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Fork pull: nicoloboschi#42

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 16, 2022
@tisonkun
Copy link
Member

/pulsarbot run-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

Merging #18956 (6f7833c) into master (3011946) will decrease coverage by 1.80%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18956      +/-   ##
============================================
- Coverage     46.75%   44.94%   -1.81%     
- Complexity    10514    10782     +268     
============================================
  Files           703      763      +60     
  Lines         68858    73615    +4757     
  Branches       7383     7916     +533     
============================================
+ Hits          32193    33085     +892     
- Misses        33065    36813    +3748     
- Partials       3600     3717     +117     
Flag Coverage Δ
unittests 44.94% <ø> (-1.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/org/apache/pulsar/proxy/stats/TopicStats.java 58.82% <0.00%> (-41.18%) ⬇️
.../apache/pulsar/broker/loadbalance/LoadManager.java 61.11% <0.00%> (-16.67%) ⬇️
...tent/PersistentDispatcherSingleActiveConsumer.java 55.17% <0.00%> (-8.78%) ⬇️
...pulsar/broker/service/PulsarCommandSenderImpl.java 73.84% <0.00%> (-4.62%) ⬇️
...ervice/AbstractDispatcherSingleActiveConsumer.java 69.15% <0.00%> (-1.87%) ⬇️
...g/apache/pulsar/broker/lookup/TopicLookupBase.java 53.63% <0.00%> (-1.68%) ⬇️
...g/apache/pulsar/broker/admin/impl/BrokersBase.java 60.45% <0.00%> (-1.37%) ⬇️
...va/org/apache/pulsar/broker/service/ServerCnx.java 48.80% <0.00%> (-1.15%) ⬇️
...ice/persistent/PersistentMessageExpiryMonitor.java 43.75% <0.00%> (-1.05%) ⬇️
...a/org/apache/pulsar/proxy/server/ProxyService.java 80.00% <0.00%> (-0.94%) ⬇️
... and 77 more

@nicoloboschi nicoloboschi merged commit e9a9364 into apache:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants