Skip to content

[fix][test] Fix flaky test PulsarMultiListenersWithoutInternalListenerNameTest.setup#19006

Merged
lhotari merged 1 commit intoapache:masterfrom
lhotari:lh-fix-flaky-freeport-detection
Dec 20, 2022
Merged

[fix][test] Fix flaky test PulsarMultiListenersWithoutInternalListenerNameTest.setup#19006
lhotari merged 1 commit intoapache:masterfrom
lhotari:lh-fix-flaky-freeport-detection

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Dec 20, 2022

Fixes #19005

Motivation

See #19005

Modifications

Change free port allocation so that both ports are detected at once. Use SO_REUSEADDR socket option for PortForwarder.

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions
Copy link

@lhotari Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Dec 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.49%. Comparing base (22866bd) to head (49667e6).
Report is 1933 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19006      +/-   ##
============================================
+ Coverage     45.92%   46.49%   +0.57%     
- Complexity    10104    10473     +369     
============================================
  Files           680      706      +26     
  Lines         66758    69004    +2246     
  Branches       7147     7392     +245     
============================================
+ Hits          30660    32085    +1425     
- Misses        32680    33321     +641     
- Partials       3418     3598     +180     
Flag Coverage Δ
unittests 46.49% <ø> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 64 files with indirect coverage changes

@lhotari lhotari merged commit 154d352 into apache:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test type/flaky-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky-test: PulsarMultiListenersWithoutInternalListenerNameTest.setup

3 participants