Skip to content

[fix][io] Include Alluxio in the distribution#19095

Merged
tisonkun merged 1 commit intoapache:masterfrom
sekikn:include-alluxio-in-distribution
Dec 29, 2022
Merged

[fix][io] Include Alluxio in the distribution#19095
tisonkun merged 1 commit intoapache:masterfrom
sekikn:include-alluxio-in-distribution

Conversation

@sekikn
Copy link
Contributor

@sekikn sekikn commented Dec 28, 2022

Motivation

Currently, the alluxio submodule is not included in the Pulsar IO distribution.

$ ./mvnw clean install -DskipTests

...

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  12:09 min
[INFO] Finished at: 2022-12-27T11:14:55+09:00
[INFO] ------------------------------------------------------------------------
$ ls -l distribution/io/target/apache-pulsar-io-connectors-2.12.0-SNAPSHOT-bin
total 1721216
-rw-r--r-- 1 sekikn sekikn     13300 12月 27 11:02 LICENSE
-rw-rw-r-- 1 sekikn sekikn   8352752 12月 27 11:02 pulsar-io-aerospike-2.12.0-SNAPSHOT.nar
-rw-rw-r-- 1 sekikn sekikn  15910726 12月 27 11:02 pulsar-io-batch-data-generator-2.12.0-SNAPSHOT.nar
...

Modifications

This PR fixes the problem above and addresses some checkstyle and OWASP issues.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as unit tests under pulsar-io/alluxio/src/test.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency): upgraded Alluxio 2.5.0 to 2.7.3 for addressing OWASP issues.
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

toc

Matching PR in forked repository

PR in forked repository: sekikn#4
There are a few failures in the BROKER_CLIENT_IMPL and OWASP tests, but I think the former is unrelated with this PR and no CVE is newly introduced in the latter.

Currently, the alluxio submodule is not included in the Pulsar IO distribution.
This PR fixes this problem and addresses some checkstyle and OWASP issues.
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Dec 28, 2022
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun
Copy link
Member

/pulsarbot run-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #19095 (a3a14d1) into master (492a9c3) will decrease coverage by 0.36%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19095      +/-   ##
============================================
- Coverage     47.46%   47.09%   -0.37%     
+ Complexity    10727    10651      -76     
============================================
  Files           711      711              
  Lines         69456    69461       +5     
  Branches       7452     7453       +1     
============================================
- Hits          32964    32712     -252     
- Misses        32810    33083     +273     
+ Partials       3682     3666      -16     
Flag Coverage Δ
unittests 47.09% <16.66%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/apache/pulsar/client/impl/ConsumerImpl.java 15.06% <0.00%> (-0.04%) ⬇️
...lsar/client/impl/conf/ClientConfigurationData.java 96.66% <100.00%> (ø)
...java/org/apache/pulsar/proxy/stats/TopicStats.java 58.82% <0.00%> (-41.18%) ⬇️
...lsar/broker/loadbalance/impl/ThresholdShedder.java 3.27% <0.00%> (-27.87%) ⬇️
.../apache/pulsar/broker/admin/impl/PackagesBase.java 54.12% <0.00%> (-13.77%) ⬇️
...org/apache/pulsar/broker/loadbalance/LoadData.java 58.33% <0.00%> (-8.34%) ⬇️
...ersistentStickyKeyDispatcherMultipleConsumers.java 51.96% <0.00%> (-7.85%) ⬇️
.../pulsar/broker/service/BrokerServiceException.java 45.45% <0.00%> (-6.37%) ⬇️
...ava/org/apache/pulsar/broker/service/Consumer.java 67.97% <0.00%> (-4.99%) ⬇️
...roker/loadbalance/impl/ModularLoadManagerImpl.java 65.26% <0.00%> (-4.03%) ⬇️
... and 36 more

@tisonkun
Copy link
Member

Merging...

@sekikn Thank you! You may use a customized release, or this patch will be included in 2.12.0.

@tisonkun tisonkun merged commit 1e59e93 into apache:master Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connector doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants