Skip to content

[improve][broker] Refactor update topic partitions endpoint. #19166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eolivelli merged 16 commits into from
Jan 18, 2023
Merged

[improve][broker] Refactor update topic partitions endpoint. #19166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
62c509b
[improve][broker] Refactor topic update partitions endpoint.
mattisonchao Jan 10, 2023
f99d1fd
Fix config check
mattisonchao Jan 10, 2023
46a733b
Fix test
mattisonchao Jan 10, 2023
d4b707d
Fix checkstyle
mattisonchao Jan 10, 2023
c1420a5
Fix failed test
mattisonchao Jan 10, 2023
450be8e
Fix test
mattisonchao Jan 12, 2023
9c5aaa6
Revert some code
mattisonchao Jan 16, 2023
31359a9
Cleanup
mattisonchao Jan 17, 2023
12e9058
Cleanup
mattisonchao Jan 17, 2023
8f354e4
Cleanup
mattisonchao Jan 17, 2023
8c42da4
Cleanup
mattisonchao Jan 17, 2023
a3bf6ec
Cleanup
mattisonchao Jan 17, 2023
89ca105
Add subscription copying
mattisonchao Jan 17, 2023
ecd1670
Fix unsupport api
mattisonchao Jan 17, 2023
8726052
Fix checkstyle
mattisonchao Jan 17, 2023
47c5015
Fix problem
mattisonchao Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,21 +165,6 @@ protected CompletableFuture<Void> tryCreatePartitionsAsync(int numPartitions) {
return FutureUtil.waitForAll(futures);
}

protected CompletableFuture<Void> tryCreateExtendedPartitionsAsync(int oldNumPartitions, int numPartitions) {
if (!topicName.isPersistent()) {
return CompletableFuture.completedFuture(null);
}
if (numPartitions <= oldNumPartitions) {
return CompletableFuture.failedFuture(new RestException(Status.NOT_ACCEPTABLE,
"Number of new partitions must be greater than existing number of partitions"));
}
List<CompletableFuture<Void>> futures = new ArrayList<>(numPartitions - oldNumPartitions);
for (int i = oldNumPartitions; i < numPartitions; i++) {
futures.add(tryCreatePartitionAsync(i));
}
return FutureUtil.waitForAll(futures);
}

private CompletableFuture<Void> tryCreatePartitionAsync(final int partition) {
CompletableFuture<Void> result = new CompletableFuture<>();
getPulsarResources().getTopicResources().createPersistentTopicAsync(topicName.getPartition(partition))
Expand Down
Loading