Skip to content

[fix][ci] Fix PulsarFunctionLocalRunTest that broke after ClusterData validation changes#19212

Merged
lhotari merged 1 commit intoapache:masterfrom
lhotari:lh-fix-PulsarFunctionLocalRunTest-resource-leak
Jan 12, 2023
Merged

[fix][ci] Fix PulsarFunctionLocalRunTest that broke after ClusterData validation changes#19212
lhotari merged 1 commit intoapache:masterfrom
lhotari:lh-fix-PulsarFunctionLocalRunTest-resource-leak

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Jan 12, 2023

Motivation

"Pulsar CI Flaky" builds fail with OOMEs and produces heap dumps.
It turns out that #19151 causes a breaking change.

In PulsarFunctionLocalRunTest, the line 275 ClusterData clusterData = ClusterData.builder().serviceUrl(urlTls.toString()).build(); didn't cause the test to fail before #19151 changes.
After the changes were made, this test started failing, but the test failure was ignored.

Modifications

  • Fix the test
  • Make changes to the test that prevent the resource leak that leads to a OOME

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: lhotari#128

@lhotari lhotari force-pushed the lh-fix-PulsarFunctionLocalRunTest-resource-leak branch from 917fab7 to 9935f35 Compare January 12, 2023 19:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Merging #19212 (9935f35) into master (d7f8f56) will decrease coverage by 13.62%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #19212       +/-   ##
=============================================
- Coverage     47.89%   34.26%   -13.63%     
+ Complexity    10871     6479     -4392     
=============================================
  Files           713      607      -106     
  Lines         69730    57677    -12053     
  Branches       7496     6004     -1492     
=============================================
- Hits          33394    19761    -13633     
- Misses        32631    35316     +2685     
+ Partials       3705     2600     -1105     
Flag Coverage Δ
unittests 34.26% <0.00%> (-13.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/apache/pulsar/client/impl/ProducerImpl.java 15.62% <0.00%> (-0.04%) ⬇️
...ava/org/apache/pulsar/broker/admin/v1/Brokers.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pulsar/broker/admin/v1/Clusters.java 0.00% <0.00%> (-100.00%) ⬇️
.../org/apache/pulsar/broker/admin/v1/Properties.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pulsar/broker/admin/v2/ResourceGroups.java 0.00% <0.00%> (-100.00%) ⬇️
...ar/common/naming/PartitionedManagedLedgerInfo.java 0.00% <0.00%> (-100.00%) ⬇️
...e/pulsar/broker/admin/impl/ResourceQuotasBase.java 0.00% <0.00%> (-96.43%) ⬇️
...he/pulsar/broker/service/AnalyzeBacklogResult.java 0.00% <0.00%> (-92.31%) ⬇️
.../apache/pulsar/broker/admin/v1/ResourceQuotas.java 0.00% <0.00%> (-91.43%) ⬇️
...e/pulsar/broker/stats/AllocatorStatsGenerator.java 0.00% <0.00%> (-91.38%) ⬇️
... and 222 more

@lhotari lhotari merged commit 7f75993 into apache:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test type/flaky-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants