[fix][ci] Fix PulsarFunctionLocalRunTest that broke after ClusterData validation changes#19212
Merged
lhotari merged 1 commit intoapache:masterfrom Jan 12, 2023
Conversation
dc61f8c to
917fab7
Compare
917fab7 to
9935f35
Compare
michaeljmarshall
approved these changes
Jan 12, 2023
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #19212 +/- ##
=============================================
- Coverage 47.89% 34.26% -13.63%
+ Complexity 10871 6479 -4392
=============================================
Files 713 607 -106
Lines 69730 57677 -12053
Branches 7496 6004 -1492
=============================================
- Hits 33394 19761 -13633
- Misses 32631 35316 +2685
+ Partials 3705 2600 -1105
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
"Pulsar CI Flaky" builds fail with OOMEs and produces heap dumps.
It turns out that #19151 causes a breaking change.
In PulsarFunctionLocalRunTest, the line 275
ClusterData clusterData = ClusterData.builder().serviceUrl(urlTls.toString()).build();didn't cause the test to fail before #19151 changes.After the changes were made, this test started failing, but the test failure was ignored.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: lhotari#128