Skip to content

[fix] [broker] print warn log if compaction task skipped cause by ex#19360

Merged
Technoboy- merged 1 commit intoapache:masterfrom
poorbarcode:fix/compaction_log
Jan 31, 2023
Merged

[fix] [broker] print warn log if compaction task skipped cause by ex#19360
Technoboy- merged 1 commit intoapache:masterfrom
poorbarcode:fix/compaction_log

Conversation

@poorbarcode
Copy link
Contributor

Motivation

If an exception occurs, the compaction task is skipped, but only prints the log at the debug level. It makes compaction that doesn't execute difficult to detect.

Modifications

change the log level to warn.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@poorbarcode poorbarcode changed the title [fix] [broker] print warn log if compaction task skipped by cause ex [fix] [broker] print warn log if compaction task skipped cause by ex Jan 30, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 30, 2023
Copy link
Contributor

@HQebupt HQebupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poorbarcode
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Merging #19360 (31be745) into master (3d8b52a) will increase coverage by 37.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #19360       +/-   ##
=============================================
+ Coverage     27.22%   64.27%   +37.04%     
- Complexity     6264    25978    +19714     
=============================================
  Files          1644     1818      +174     
  Lines        123745   133126     +9381     
  Branches      13495    14646     +1151     
=============================================
+ Hits          33693    85568    +51875     
+ Misses        84932    39739    -45193     
- Partials       5120     7819     +2699     
Flag Coverage Δ
inttests 24.94% <0.00%> (?)
systests 25.60% <0.00%> (+0.11%) ⬆️
unittests 61.54% <0.00%> (+43.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sar/broker/service/persistent/PersistentTopic.java 65.90% <0.00%> (+22.52%) ⬆️
...in/java/org/apache/pulsar/common/api/AuthData.java 71.42% <0.00%> (ø)
...ava/org/apache/pulsar/client/api/schema/Field.java 80.00% <0.00%> (ø)
.../apache/pulsar/broker/namespace/LookupOptions.java 87.50% <0.00%> (ø)
...apache/pulsar/common/util/SafeCollectionUtils.java 0.00% <0.00%> (ø)
...org/apache/pulsar/common/io/BatchSourceConfig.java 50.00% <0.00%> (ø)
...pache/pulsar/common/configuration/BindAddress.java 22.22% <0.00%> (ø)
...g/apache/pulsar/common/functions/WindowConfig.java 92.85% <0.00%> (ø)
...apache/pulsar/common/functions/ConsumerConfig.java 87.50% <0.00%> (ø)
...apache/pulsar/common/functions/ProducerConfig.java 90.00% <0.00%> (ø)
... and 1292 more

@Technoboy- Technoboy- merged commit 72b2e7e into apache:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants