[fix][ci] Fix pulsar shell bin file name#19378
Merged
nicoloboschi merged 2 commits intoapache:masterfrom Feb 1, 2023
yaalsn:fix-pulsar-shell-bin-path
Merged
[fix][ci] Fix pulsar shell bin file name#19378nicoloboschi merged 2 commits intoapache:masterfrom yaalsn:fix-pulsar-shell-bin-path
nicoloboschi merged 2 commits intoapache:masterfrom
yaalsn:fix-pulsar-shell-bin-path
Conversation
Contributor
nicoloboschi
left a comment
There was a problem hiding this comment.
In the current master the names are:
- apache-pulsar-shell-2.12.0-SNAPSHOT-bin.tar.gz
- apache-pulsar-shell-2.12.0-SNAPSHOT-bin.zip
maybe this is only related to branch-2.11 ?
Contributor
Author
For master and branch-2.11, both have |
Contributor
Author
Contributor
I have fixed this on branch-2.11 when releasing 2.11 |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
nicoloboschi
approved these changes
Feb 1, 2023
Codecov Report
@@ Coverage Diff @@
## master #19378 +/- ##
=============================================
+ Coverage 26.61% 62.84% +36.22%
- Complexity 6358 25614 +19256
=============================================
Files 1568 1822 +254
Lines 120927 133218 +12291
Branches 13216 14669 +1453
=============================================
+ Hits 32189 83720 +51531
+ Misses 84128 41794 -42334
- Partials 4610 7704 +3094
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
The shell distribution files' name are like
apache-pulsar-shell-$VERSION-shell-bin.tar.gzandapache-pulsar-shell-$VERSION-shell-bin.zipwhich are incorrect instage-release.sh.Modifications
Add suffix
-binVerifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: https://github.com/yaalsn/pulsar/pull/17