[cleanup] Remove legacy preview instructions#19380
Merged
Conversation
Member
|
@tisonkun thanks for your contribution! While I think we still need this label because some descriptions made to code files belong to For example, sometimes engineers will update the descriptions in the Java admin API code files (left), actually, they are rendered as Java admin API reference docs (right). In this way, the PR should be labeled with This is similar for:
|
Member
Author
|
Hi @Anonymitaet , this PR doesn't remove the label but update the comment :) Please take a closer look on the diff. |
Member
|
Oops, sorry my fault! I thought it was removed. I've approved this PR. |
Anonymitaet
approved these changes
Feb 1, 2023
momo-jun
approved these changes
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation
docdoc-requireddoc-not-neededdoc-complete