Skip to content

Comments

[fix][broker] Validate per-[namespace][topic] entry filters#19422

Merged
nicoloboschi merged 2 commits intoapache:masterfrom
nicoloboschi:fix-entry-filters-validation
Feb 3, 2023
Merged

[fix][broker] Validate per-[namespace][topic] entry filters#19422
nicoloboschi merged 2 commits intoapache:masterfrom
nicoloboschi:fix-entry-filters-validation

Conversation

@nicoloboschi
Copy link
Contributor

Motivation

When setting entry filters for namespace/topic there's no check that the entry filters exist and were correctly loaded by the broker. Since the actual entry filters classloaders are loaded in an async way, it's possible to corrupt the entry filters in the policies (it gets back to the broker config) returning OK to the API call. The only way to detect the entry filters is not working it's to look at the broker log (since the GET api call will return the content of the policies).

Modifications

  • During the POST method the entry filters are validated. Validated means the entry filter name exists in the broker.
  • Fixed the GET method with applied=true that wasn't taking into account the global ´AllowOverrideEntryFilters´ broker flag. Also it was mixing sync/async operations

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 3, 2023
@nicoloboschi
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@nicoloboschi nicoloboschi merged commit 75d58fd into apache:master Feb 3, 2023
@nicoloboschi nicoloboschi deleted the fix-entry-filters-validation branch February 3, 2023 19:41
@Technoboy- Technoboy- added this to the 3.0.0 milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants