[fix][broker] Validate per-[namespace][topic] entry filters#19422
Merged
nicoloboschi merged 2 commits intoapache:masterfrom Feb 3, 2023
Merged
[fix][broker] Validate per-[namespace][topic] entry filters#19422nicoloboschi merged 2 commits intoapache:masterfrom
nicoloboschi merged 2 commits intoapache:masterfrom
Conversation
eolivelli
approved these changes
Feb 3, 2023
Contributor
Author
|
/pulsarbot rerun-failure-checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When setting entry filters for namespace/topic there's no check that the entry filters exist and were correctly loaded by the broker. Since the actual entry filters classloaders are loaded in an async way, it's possible to corrupt the entry filters in the policies (it gets back to the broker config) returning OK to the API call. The only way to detect the entry filters is not working it's to look at the broker log (since the GET api call will return the content of the policies).
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete