[branch-2.11] [fix] [ml] Change the modifier of some variables in ManagedLedgerImpl to default to resolve compilation errors#19453
Closed
poorbarcode wants to merge 1 commit intoapache:branch-2.11from
Closed
Conversation
…agedLedgerImpl to default to resolve compilation errors
Technoboy-
approved these changes
Feb 8, 2023
Contributor
|
Hi @Technoboy- , I think this PR cannot pass the CI because its target is branch-2.11, not master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The modifier of variables
currentLedgerEntries,currentLedgerSizeandcurrentLedgerinManagedLedegrImplchanged toprotectedin PR #18265, this PR is for new features, so there is no cherry picking to branch2.11.PR #19404 fixes the problem of the managed ledger, and is already cherry-picked into branch
2.11, but this PR uses the above change( The modifier changes of some variables ), so the compilation of branch2.11errors now.Modifications
currentLedgerEntries,currentLedgerSizeandcurrentLedgertodefaultDocumentation
docdoc-requireddoc-not-neededdoc-complete