[fix][test] flaky test: testOnlyCloseActiveConsumerForSingleActiveConsumerDispatcherWhenSeek#19572
Merged
Merged
Conversation
|
@labuladong Please add the following content to your PR description and select a checkbox: |
Technoboy-
approved these changes
Feb 20, 2023
Contributor
|
/pulsarbot rerun-failure-checks |
1 similar comment
Contributor
|
/pulsarbot rerun-failure-checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19572 +/- ##
=============================================
+ Coverage 24.65% 62.07% +37.41%
- Complexity 291 3491 +3200
=============================================
Files 1591 1844 +253
Lines 123073 135280 +12207
Branches 13434 14875 +1441
=============================================
+ Hits 30348 83972 +53624
+ Misses 88233 43582 -44651
- Partials 4492 7726 +3234
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
coderzc
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19535
Modifications
Original code only guarantee one consumer reconnected, the other consumer may not finish reconnecting, so there is only one consumer in subscription. Now use
Awaitilityto guarantee two consumers reconnected.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete