Skip to content

[fix][test] flaky test: testOnlyCloseActiveConsumerForSingleActiveConsumerDispatcherWhenSeek#19572

Merged
Technoboy- merged 1 commit into
apache:masterfrom
labuladong:fix/issue/19535
Feb 21, 2023
Merged

[fix][test] flaky test: testOnlyCloseActiveConsumerForSingleActiveConsumerDispatcherWhenSeek#19572
Technoboy- merged 1 commit into
apache:masterfrom
labuladong:fix/issue/19535

Conversation

@labuladong
Copy link
Copy Markdown
Contributor

@labuladong labuladong commented Feb 20, 2023

Fixes #19535

Modifications

Original code only guarantee one consumer reconnected, the other consumer may not finish reconnecting, so there is only one consumer in subscription. Now use Awaitility to guarantee two consumers reconnected.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions
Copy link
Copy Markdown

@labuladong Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@Technoboy- Technoboy- added this to the 3.0.0 milestone Feb 20, 2023
@Technoboy- Technoboy- closed this Feb 20, 2023
@Technoboy- Technoboy- reopened this Feb 20, 2023
@Technoboy-
Copy link
Copy Markdown
Contributor

/pulsarbot rerun-failure-checks

1 similar comment
@Technoboy-
Copy link
Copy Markdown
Contributor

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 21, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.07%. Comparing base (e0b50c9) to head (deeae18).
⚠️ Report is 2814 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #19572       +/-   ##
=============================================
+ Coverage     24.65%   62.07%   +37.41%     
- Complexity      291     3491     +3200     
=============================================
  Files          1591     1844      +253     
  Lines        123073   135280    +12207     
  Branches      13434    14875     +1441     
=============================================
+ Hits          30348    83972    +53624     
+ Misses        88233    43582    -44651     
- Partials       4492     7726     +3234     
Flag Coverage Δ
inttests 24.67% <ø> (+0.01%) ⬆️
systests 25.28% <ø> (?)
unittests 59.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1378 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Technoboy- Technoboy- merged commit 8ec6511 into apache:master Feb 21, 2023
@labuladong labuladong deleted the fix/issue/19535 branch February 21, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test type/flaky-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky-test: SubscriptionSeekTest.testOnlyCloseActiveConsumerForSingleActiveConsumerDispatcherWhenSeek

4 participants