[fix] [test] fix flaky test PersistentFailoverE2ETest.testSimpleConsumerEventsWithPartition#19574
Merged
Technoboy- merged 3 commits intoFeb 21, 2023
Conversation
…merEventsWithPartition
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #19574 +/- ##
=============================================
+ Coverage 24.65% 62.13% +37.47%
- Complexity 291 25726 +25435
=============================================
Files 1591 1844 +253
Lines 123073 135280 +12207
Branches 13434 14875 +1441
=============================================
+ Hits 30348 84060 +53712
+ Misses 88233 43494 -44739
- Partials 4492 7726 +3234
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The single consumer dispatcher selects consumer according to the name order of consumers. The test
testSimpleConsumerEventsWithPartitionis also written according to this rule. After PR [improve][broker] introduce consistent hash ring to distribute the load of multiple topics subscription #19502, the dispatcher no longer selects consumers in the order of registration, so the test becomes unstable.And the same thing is true for
PersistentDispatcherFailoverConsumerTest.testAddRemoveConsumerNonPartitionedTopicIn the original implementation, non-partitioned topic did not care about the priority of consumers, but after PR [improve][broker] introduce consistent hash ring to distribute the load of multiple topics subscription #19502, it began to care about the priority of consumers, which also led to the instability of
PersistentDispatcherFailoverConsumerTest.testAddRemoveConsumerNonPartitionedTopictestModifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: