[fix][test]testRedirectOfGetCoordinatorInternalStats#19715
Merged
liangyepianzhou merged 2 commits intoapache:masterfrom Mar 9, 2023
liangyepianzhou:xiangying/flaky-test/testRedirectOfGetCoordinatorInternalStats
Merged
[fix][test]testRedirectOfGetCoordinatorInternalStats#19715liangyepianzhou merged 2 commits intoapache:masterfrom liangyepianzhou:xiangying/flaky-test/testRedirectOfGetCoordinatorInternalStats
liangyepianzhou merged 2 commits intoapache:masterfrom
liangyepianzhou:xiangying/flaky-test/testRedirectOfGetCoordinatorInternalStats
Conversation
poorbarcode
reviewed
Mar 6, 2023
| new PartitionedTopicMetadata(NUM_PARTITIONS)); | ||
| map = admin.lookups().lookupPartitionedTopic(SystemTopicNames.TRANSACTION_COORDINATOR_ASSIGN.toString()); | ||
|
|
||
| for (int i = 0; map.containsValue(getPulsarServiceList().get(i).getBrokerServiceUrl()); i++) { |
Contributor
There was a problem hiding this comment.
Why not create a new admin connected to the broker who not contains the TXN coordinator?
poorbarcode
approved these changes
Mar 6, 2023
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #18600
Motivation
Reason for test failure:
Modifications
Do not recreate the transaction coordinator topics.
Recreate an admin connect the broker which is not the owner of the transaction coordinator topics.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: