[improve][meta] Fix busy-loop causes watcher can't acquire lock.#19769
Merged
mattisonchao merged 11 commits intoapache:masterfrom Mar 13, 2023
mattisonchao:fix/test/zksession
Merged
[improve][meta] Fix busy-loop causes watcher can't acquire lock.#19769mattisonchao merged 11 commits intoapache:masterfrom mattisonchao:fix/test/zksession
mattisonchao merged 11 commits intoapache:masterfrom
mattisonchao:fix/test/zksession
Conversation
Member
|
@mattisonchao isn't this a problem that also impacts our maintenance branches and actual production code? |
Member
Author
|
@lhotari |
coderzc
approved these changes
Mar 10, 2023
Member
coderzc
left a comment
coderzc
left a comment
There was a problem hiding this comment.
LGTM
Also fix the same issue in the EtcdSessionWatcher?
Member
Author
I don't think so, because ETCD has no notification mechanism. Therefore, I think ETCD Session watcher has no problem. |
mattisonchao
changed the title
Technoboy-
approved these changes
Mar 12, 2023
codelipenghui
approved these changes
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11032
Master Issue: #11032
Motivation
Due to the session timeout time being too small, it will cause the scheduler to be in busy loop status and give no chance for other threads(
process method) to get the synchronous lock.This behaviour may affect the notification order and make the test fail.
Modifications
scheduleWithFixedDelayto avoid a busy loop.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete