[fix][doc] The messageIds in onNegativeAcksSend shouldn't be null#19852
Merged
RobertIndie merged 2 commits intoapache:masterfrom Mar 21, 2023
Merged
[fix][doc] The messageIds in onNegativeAcksSend shouldn't be null#19852RobertIndie merged 2 commits intoapache:masterfrom
messageIds in onNegativeAcksSend shouldn't be null#19852RobertIndie merged 2 commits intoapache:masterfrom
Conversation
Signed-off-by: Zike Yang <zike@apache.org>
RobertIndie
added
type/bug
momo-jun
reviewed
Mar 20, 2023
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerInterceptor.java
Outdated
Show resolved
Hide resolved
…onsumerInterceptor.java Co-authored-by: Jun Ma <60642177+momo-jun@users.noreply.github.com>
AnonHxy
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
onNegativeAcksSendis only called by:pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/NegativeAcksTracker.java
Line 83 in 80c5791
It will not be null. The statement
null if acknowledge fail.is incorrect.Modifications
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: