[fix][broker]: validation for at least one TlsUrl / nonTlsUrl is present for cluster creation/update#19965
Closed
niharrathod wants to merge 8 commits intoapache:masterfrom
Closed
[fix][broker]: validation for at least one TlsUrl / nonTlsUrl is present for cluster creation/update#19965niharrathod wants to merge 8 commits intoapache:masterfrom
niharrathod wants to merge 8 commits intoapache:masterfrom
Conversation
…sent for cluster creation apache#19866 * Introduced validation 1. at least one valid serviceUrl/serviceUrlTls set 2. at least one valid brokerServiceUrl/brokerServiceUrlTls set
Contributor
Author
|
At first site this looks big change, but actual changes are only in two files ClustersBase.java, ClusterDataImpl.java where validation is added, unit test w.r.t same in ClusterDataTest.java, rest 115 file diff is because of patching existing test cases, where brokerServiceUrl is set to satisfy the validation. Kindly requesting for a review. I am happy to discuss & do any improvisation / further work if needed. |
2 tasks
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19866
Motivation
Verify either TlsUrl or nonTlsUrl is provided as part of Cluster create and update operation.
This validation is not applicable for "global" cluster create / update operation.
Modifications
Core changes are only in two files ClustersBase.java, ClusterDataImpl.java, added unit test w.r.t same in ClusterDataTest.java
rest 115 file diff is because of patching existing test cases.
Verifying this change
This change added can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: