[improve][broker] Recover batch deleted Index when cursor recover from metadataStore.#20018
Open
lifepuzzlefun wants to merge 4 commits intoapache:masterfrom
Open
Conversation
Member
|
Good catch. Please add tests to cover this PR. The test should fail without the fix and pass with the fix in this PR. |
Contributor
Author
|
@lhotari @codelipenghui @Technoboy- can you take a look ? |
|
The pr had no activity for 30 days, mark with Stale label. |
lhotari
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fix #20585
just add the logic the same as
recoverFromLedger(ManagedCursorInfo,VoidCallback)to therecover(VoidCallback)pulsar/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
Lines 597 to 606 in bbf5273
i think both the logic is the same either recover from metadataStore or cursorLedger.
Modifications
add logic on recoverBatchDeletedIndex .
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: