[refactor][test] Replace Anonymous type with lambda.#20217
Closed
liqiangcc wants to merge 1 commit intoapache:masterfrom
liqiangcc:master
Closed
[refactor][test] Replace Anonymous type with lambda.#20217liqiangcc wants to merge 1 commit intoapache:masterfrom liqiangcc:master
liqiangcc wants to merge 1 commit intoapache:masterfrom
liqiangcc:master
Conversation
tisonkun
requested changes
May 3, 2023
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
We don't have such style rule. So generally we don't format code to prevent conflict when cherry-picking. Different people have different preference. If you'd like to make this style a formal rule, feel free to start a discussion on the dev mailing list and update the style guide.
FYI -
Member
|
Closing... |
Member
|
In another direction, you can make any effective improvement, bug fix or new feature, apply your style on the fly when modifying related code. |
Contributor
Author
|
I suppose so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Replace Anonymous type with lambda.
Modifications
Replace Anonymous type with lambda.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: