[improve][doc] Remove javadoc reference to old default 30s ack timeout impl#20377
Merged
Merged
Conversation
merlimat
approved these changes
May 23, 2023
michaeljmarshall
approved these changes
May 24, 2023
Member
michaeljmarshall
left a comment
There was a problem hiding this comment.
LGTM. Thanks @GerMoranOverstock!
Member
|
/pulsarbot rerun-failure-checks |
tisonkun
approved these changes
May 24, 2023
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20377 +/- ##
=============================================
+ Coverage 25.11% 72.93% +47.81%
- Complexity 205 31894 +31689
=============================================
Files 1680 1864 +184
Lines 127176 138384 +11208
Branches 13863 15183 +1320
=============================================
+ Hits 31942 100931 +68989
+ Misses 90242 29446 -60796
- Partials 4992 8007 +3015
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
|
Merging... Thanks for your contribution @GerMoranOverstock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #19486
Motivation
Remove ambiguity around this setting being 30s default per the other docs
Modifications
Updated the javadoc to align with the current implementation and as described in other areas of the documentation.
Verifying this change
[x] This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: