Skip to content

[improve][doc] Remove javadoc reference to old default 30s ack timeout impl#20377

Merged
tisonkun merged 1 commit into
apache:masterfrom
GerMoranBYON:update_javadoc_acktimeout
May 24, 2023
Merged

[improve][doc] Remove javadoc reference to old default 30s ack timeout impl#20377
tisonkun merged 1 commit into
apache:masterfrom
GerMoranBYON:update_javadoc_acktimeout

Conversation

@GerMoranBYON
Copy link
Copy Markdown
Contributor

Master Issue: #19486

Motivation

Remove ambiguity around this setting being 30s default per the other docs

Modifications

Updated the javadoc to align with the current implementation and as described in other areas of the documentation.

Verifying this change

  • Make sure that the change passes the CI checks.

[x] This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@GerMoranBYON GerMoranBYON changed the title [improve][doc] Remove java reference to old default 30s ack timeout impl [improve][doc] Remove javadoc reference to old default 30s ack timeout impl May 23, 2023
@github-actions github-actions Bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label May 23, 2023
Copy link
Copy Markdown
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @GerMoranOverstock!

@michaeljmarshall
Copy link
Copy Markdown
Member

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 24, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.93%. Comparing base (f20dc93) to head (535cc35).
⚠️ Report is 2726 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #20377       +/-   ##
=============================================
+ Coverage     25.11%   72.93%   +47.81%     
- Complexity      205    31894    +31689     
=============================================
  Files          1680     1864      +184     
  Lines        127176   138384    +11208     
  Branches      13863    15183     +1320     
=============================================
+ Hits          31942   100931    +68989     
+ Misses        90242    29446    -60796     
- Partials       4992     8007     +3015     
Flag Coverage Δ
inttests 24.17% <ø> (?)
systests 24.96% <ø> (-0.15%) ⬇️
unittests 72.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1547 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tisonkun
Copy link
Copy Markdown
Member

Merging...

Thanks for your contribution @GerMoranOverstock

@tisonkun tisonkun merged commit 0e7056b into apache:master May 24, 2023
@GerMoranBYON GerMoranBYON deleted the update_javadoc_acktimeout branch May 24, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants