[improve][ci] Improve TestNG test execution to debug flaky test failures#20425
Merged
tisonkun merged 1 commit intoapache:masterfrom May 29, 2023
Merged
Conversation
- Log possible exceptions before retrying a test run - this will help debug issues when tests are retried - Don't log anything when skipping is a result of fail fast mode (SkipException) - Execute cleanup methods when using fail fast mode - the change in apache#19252 broke the logic that intends to run cleanup methods after the first failure
This was referenced May 29, 2023
Codecov Report
@@ Coverage Diff @@
## master #20425 +/- ##
============================================
- Coverage 72.90% 72.90% -0.01%
- Complexity 31864 31877 +13
============================================
Files 1864 1865 +1
Lines 138416 138439 +23
Branches 15188 15192 +4
============================================
+ Hits 100919 100932 +13
- Misses 29477 29491 +14
+ Partials 8020 8016 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tisonkun
approved these changes
May 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In order to investigate some flaky test failures such as #20386, it is necessary to add logging to find out what was the failure of the first attempt. In some cases, the exception in the test retry is not the root cause.
In the case of #20386, there's "Index 0 out of bounds for length 0" recorded in the skip message:
However, the full exception isn't logged.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete