[fix][test] Fix resource leak in PulsarServiceTest#21386
Merged
lhotari merged 1 commit intoapache:masterfrom Oct 18, 2023
Merged
[fix][test] Fix resource leak in PulsarServiceTest#21386lhotari merged 1 commit intoapache:masterfrom
lhotari merged 1 commit intoapache:masterfrom
Conversation
lhotari
requested review from
Technoboy-,
codelipenghui,
mattisonchao and
tisonkun
mattisonchao
approved these changes
Oct 17, 2023
Codecov Report
@@ Coverage Diff @@
## master #21386 +/- ##
=============================================
+ Coverage 34.55% 73.27% +38.72%
- Complexity 12096 32576 +20480
=============================================
Files 1711 1888 +177
Lines 130647 140246 +9599
Branches 14236 15411 +1175
=============================================
+ Hits 45142 102772 +57630
+ Misses 79490 29404 -50086
- Partials 6015 8070 +2055
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PulsarServiceTest leaks 141 threads currently.
Modifications
Properly close resources in the test.
Documentation
docdoc-requireddoc-not-neededdoc-complete