Skip to content

Conversation

@hanmz
Copy link
Contributor

@hanmz hanmz commented Oct 20, 2023

Motivation

Fix typos in AuthenticationDataProvider interface

Modifications

Modify the interface name from getTlsCerificateFilePath to getTlsCertificateFilePath

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 20, 2023
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

To eliminate typos, you may take a look at https://github.com/crate-ci/typos and see if we can integrate it into Pulsar repo - this can be a non-trivial work.

@hanmz
Copy link
Contributor Author

hanmz commented Oct 20, 2023

/pulsarbot rerun-failure-checks

@tisonkun tisonkun merged commit e3debb9 into apache:master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants