[improve][broker] Refactor method BrokerService#unloadServiceUnit#21463
Closed
mattisonchao wants to merge 2 commits intoapache:masterfrom
mattisonchao:improve/broker_service_unloadServiceUnit
Closed
[improve][broker] Refactor method BrokerService#unloadServiceUnit#21463mattisonchao wants to merge 2 commits intoapache:masterfrom mattisonchao:improve/broker_service_unloadServiceUnit
mattisonchao wants to merge 2 commits intoapache:masterfrom
mattisonchao:improve/broker_service_unloadServiceUnit
Conversation
AnonHxy
reviewed
Oct 30, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Refactor method BrokerService#unloadServiceUnit to improve exception handling, logging and method call.
Modifications
topicCreationFutureTimeoutExceptionwhen the method running timeout.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete