Don't dirty the tree when building in CI#2175
Merged
sijie merged 1 commit intoapache:masterfrom Jul 17, 2018
Merged
Conversation
When we build a package, mvn inserts the sha of the commit we are building from into the tarball. If there have been any changes to the work tree, it will add the suffix "(dirty)". CI makes a couple of modifications to the worktree. It creates its own .repository for maven artifacts. And it create a docker debugging logfile. This patch adds these to .gitignore so that they won't be picked up by git status and won't cause the tree to be 'dirty'.
ivankelly
changed the title
sijie
approved these changes
Jul 17, 2018
Member
|
retest this please |
sijie
added
type/enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we build a package, mvn inserts the sha of the commit we are
building from into the tarball. If there have been any changes to the
work tree, it will add the suffix "(dirty)".
CI makes a couple of modifications to the worktree. It creates its own
.repository for maven artifacts. And it create a docker debugging
logfile.
This patch adds these to .gitignore so that they won't be picked up by
git status and won't cause the tree to be 'dirty'.