[improve] [broker] Enable AppendBrokerTimestampMetadataInterceptor by default#21939
Closed
315157973 wants to merge 10 commits intoapache:masterfrom
Closed
[improve] [broker] Enable AppendBrokerTimestampMetadataInterceptor by default#21939315157973 wants to merge 10 commits intoapache:masterfrom
315157973 wants to merge 10 commits intoapache:masterfrom
Conversation
[fix][test]Fix resource not close after method
|
@315157973 Please add the following content to your PR description and select a checkbox: |
Jason918
reviewed
Jan 26, 2024
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java
Outdated
Show resolved
Hide resolved
Jason918
reviewed
Feb 18, 2024
Contributor
Jason918
left a comment
There was a problem hiding this comment.
LGTM. But do we need a PIP to change the default config value?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Issue: #21347
Motivation
When the client machine's clock is incorrect (eg: set to 1 year later) and the Broker does not set the AppendBrokerTimestampMetadataInterceptor, the Ledger will not be cleaned up.
Because if the Broker's timestamp is not set, the expiration check will be based on the client's publish time.
As we discuss in https://lists.apache.org/thread/0vtjt436xvlg0fr4ogchkjdvjcp56mvz
Modifications
Enable
AppendBrokerTimestampMetadataInterceptorby defaultVerifying this change
Does this pull request potentially affect one of the following parts:
The default values of configurations
doc-not-neededMatching PR in forked repository
PR in forked repository: 315157973#13