[fix][txn] Fix SnapshotSegmentAbortedTxnProcessorImpl thread safety issue#22384
Open
nikam14 wants to merge 4 commits intoapache:masterfrom
Open
[fix][txn] Fix SnapshotSegmentAbortedTxnProcessorImpl thread safety issue#22384nikam14 wants to merge 4 commits intoapache:masterfrom
nikam14 wants to merge 4 commits intoapache:masterfrom
Conversation
lhotari
requested changes
Apr 5, 2024
Member
lhotari
left a comment
There was a problem hiding this comment.
Thanks for the contribution @nikam14 .
Unfortunately fixing these issues isn't simple. This PR might be doing the right things, but without proper concurrency tests, it's hard to ensure that adding synchronized methods doesn't cause regressions such as dead-locks. The lack of tests isn't caused by this PR, but to get confidence for merging such PRs, it would have to be resolved.
Just viewing the code won't be a sufficient review.
Contributor
Author
|
Thanks for the explanation @lhotari |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22116
Motivation
Fix SnapshotSegmentAbortedTxnProcessorImpl thread safety issue
Modifications
volatilekeyword to unsealedtxnIds variable.synchronizedkeyword for data consistencyVerifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: