Skip to content

[improve] [broker] add role for consumer stat#22561

Closed
thetumbled wants to merge 16 commits into
apache:masterfrom
thetumbled:AddRoleForConsumerStat
Closed

[improve] [broker] add role for consumer stat#22561
thetumbled wants to merge 16 commits into
apache:masterfrom
thetumbled:AddRoleForConsumerStat

Conversation

@thetumbled
Copy link
Copy Markdown
Member

@thetumbled thetumbled commented Apr 23, 2024

Motivation

By config allowAutoSubscriptionCreation, we allow uses to create subscriptions automatically if user have the consume permission. We have a strong need to trace back who is the owner of a specific subscription, but currently there is no such way to achieve that.

Modifications

Add field role in the stats response.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions Bot added the doc-required Your PR changes impact docs and you will update later. label Apr 23, 2024
@thetumbled thetumbled closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required Your PR changes impact docs and you will update later.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant