Skip to content

Conversation

@falser101
Copy link
Contributor

@falser101 falser101 commented Aug 4, 2025

Main Issue: #24585

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions
Copy link

github-actions bot commented Aug 4, 2025

@falser101 Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@falser101 falser101 changed the title [Enhancement] Add dependency file name information to error message when .nar file validation fails with ZipException # [improve][io] Add dependency file name information to error message when .nar file validation fails with ZipException # Aug 4, 2025
@falser101 falser101 changed the title [improve][io] Add dependency file name information to error message when .nar file validation fails with ZipException # [improve][io] Add dependency file name information to error message when .nar file validation fails with ZipException Aug 4, 2025
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Aug 4, 2025
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are unrelated changes in this PR.
One of the problems is that you are using your master branch for this PR. It's recommended to create a unique PR branch for each PR so that you can have multiple outstanding PRs. You won't be able to use "Personal CI" if you are using the master branch in your own fork. When contributing to apache/pulsar, you can run CI in your own fork with the "Personal CI" instructions, as long as you have a unique branch name.

Another useful change would be to add some tests to ensure that this solution works. It's not absolutely necessary since we don't require 100% test coverage, but it's useful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be related to the issue that is being resolved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be related to the issue that is being resolved.

@falser101 falser101 closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants