Skip to content

[fix][test] Fix flaky OneWayReplicatorUsingGlobalZKTest cleanup#25313

Merged
lhotari merged 1 commit intoapache:masterfrom
merlimat:fix-flaky-test
Mar 12, 2026
Merged

[fix][test] Fix flaky OneWayReplicatorUsingGlobalZKTest cleanup#25313
lhotari merged 1 commit intoapache:masterfrom
merlimat:fix-flaky-test

Conversation

@merlimat
Copy link
Contributor

@merlimat merlimat commented Mar 11, 2026

Summary

  • Fix flaky OneWayReplicatorUsingGlobalZKTest.cleanup that fails with HTTP 422
  • When using global ZK, reducing replication clusters triggers async topic cleanup on removed clusters. The namespace force-delete can fail if topics are still in a transitional state.
  • Wrap deleteNamespace calls with Awaitility retry to handle this race condition.

Test plan

  • Existing tests pass — the change only affects test cleanup resilience
  • Verify OneWayReplicatorUsingGlobalZKTest no longer fails during cleanup

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

When using global ZK, reducing replication clusters triggers async
topic cleanup on removed clusters. The namespace force-delete can
fail with HTTP 422 if topics are still in a transitional state.
Retry namespace deletion with Awaitility to handle this race.
@apache apache deleted a comment from github-actions bot Mar 11, 2026
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Mar 11, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.65%. Comparing base (6c357f6) to head (afcffbc).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #25313      +/-   ##
============================================
+ Coverage     72.54%   72.65%   +0.10%     
- Complexity    34627    34647      +20     
============================================
  Files          1967     1967              
  Lines        156326   156326              
  Branches      17812    17812              
============================================
+ Hits         113409   113571     +162     
+ Misses        33814    33675     -139     
+ Partials       9103     9080      -23     
Flag Coverage Δ
inttests 25.57% <ø> (?)
systests 22.28% <ø> (-0.07%) ⬇️
unittests 73.61% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 99 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit d0fa363 into apache:master Mar 12, 2026
74 of 79 checks passed
@merlimat merlimat deleted the fix-flaky-test branch March 12, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants