Skip to content

[fix][test] Fix flaky PulsarDebeziumOracleSourceTest#25314

Merged
lhotari merged 1 commit intoapache:masterfrom
merlimat:fix-flaky-oracle-test
Mar 11, 2026
Merged

[fix][test] Fix flaky PulsarDebeziumOracleSourceTest#25314
lhotari merged 1 commit intoapache:masterfrom
merlimat:fix-flaky-oracle-test

Conversation

@merlimat
Copy link
Contributor

@merlimat merlimat commented Mar 11, 2026

Summary

  • Fix flaky PulsarDebeziumOracleSourceTest.testDebeziumOracleDbSource that fails with Oracle did not initialize properly
  • The Oracle container may not reach MOUNTED status after startup mount if it is still completing shutdown
  • Add retry logic for the startup mount command (up to 3 attempts)
  • Add progress logging to waitForOracleStatus every 30 seconds so failures are diagnosable
  • Catch exceptions during status polling since sqlplus can fail during Oracle state transitions
  • Include last observed stdout/stderr in the failure message

Test plan

  • Existing tests pass — the change only affects Oracle initialization resilience
  • Verify PulsarDebeziumOracleSourceTest no longer fails during Oracle startup

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

The Oracle container may not reach MOUNTED status after `startup mount`
if it is still completing shutdown. This causes the test to fail with
"Oracle did not initialize properly".

- Add retry logic for the `startup mount` command
- Add progress logging to `waitForOracleStatus` so failures are
  diagnosable
- Catch exceptions during status polling since sqlplus can fail
  during Oracle state transitions
- Include last observed stdout/stderr in the failure message
@merlimat merlimat force-pushed the fix-flaky-oracle-test branch from 3214b55 to 61ff2df Compare March 11, 2026 19:40
@apache apache deleted a comment from github-actions bot Mar 11, 2026
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Mar 11, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.62%. Comparing base (6c357f6) to head (61ff2df).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #25314      +/-   ##
============================================
+ Coverage     72.54%   72.62%   +0.07%     
- Complexity    34627    34631       +4     
============================================
  Files          1967     1967              
  Lines        156326   156326              
  Branches      17812    17812              
============================================
+ Hits         113409   113529     +120     
+ Misses        33814    33710     -104     
+ Partials       9103     9087      -16     
Flag Coverage Δ
inttests 25.58% <ø> (?)
systests 22.31% <ø> (-0.04%) ⬇️
unittests 73.59% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 87 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit b171b05 into apache:master Mar 11, 2026
71 of 75 checks passed
@merlimat merlimat deleted the fix-flaky-oracle-test branch March 11, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants