[improve][offload] PIP-461: Add queued latency metrics for offloader executors#25321
Draft
BewareMyPower wants to merge 1 commit intoapache:masterfrom
Draft
[improve][offload] PIP-461: Add queued latency metrics for offloader executors#25321BewareMyPower wants to merge 1 commit intoapache:masterfrom
BewareMyPower wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
I will write a proposal for it since it adds new metrics |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
BlobStoreManagedLedgerOffloaderusesOrderedSchedulerinstances for both offload/write work and read work, but those executors currently do not expose an offloader-specific queued-latency metric.The jcloud offloader runs blocking blob-store operations on these executors:
schedulerhandles synchronous offload and delete work.readExecutorhandles blocking offloaded-ledger open/read/close work.When these tasks queue up behind other blocking work, it is hard to tell from the existing offloader metrics whether the executors themselves are saturated.
Modifications
This change adds two new offloader metrics:
brk_ledgeroffloader_offload_executor_queue_latencybrk_ledgeroffloader_read_offload_executor_queue_latencyThe implementation:
LedgerOffloaderStatsandLedgerOffloaderStatsImplwith the two queue-latency summaries.schedulerandreadExecutor.The queue-latency metrics use the same topic/namespace label behavior as the existing ledger offloader metrics.
Verifying this change
This change added tests and can be verified as follows:
./mvnw -pl managed-ledger -Dmaven.test.skip=true install./mvnw -pl tiered-storage/jcloud -Dtest=BlobStoreManagedLedgerOffloaderTest,BlobStoreBackedReadHandleImplTest -Dsurefire.failIfNoSpecifiedTests=false testNotes:
pulsar-brokertest class was not run locally because this checkout currently has unrelated compile failures inpulsar-broker/pulsar-metadata.Does this pull request potentially affect one of the following parts:
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: N/A