[cleanup] Convert 30 test classes to SharedPulsarBaseTest#25381
Merged
merlimat merged 3 commits intoapache:masterfrom Mar 23, 2026
Merged
[cleanup] Convert 30 test classes to SharedPulsarBaseTest#25381merlimat merged 3 commits intoapache:masterfrom
merlimat merged 3 commits intoapache:masterfrom
Conversation
AdminTopicApiTest, AnalyzeBacklogSubscriptionTest, ClientMetricsTest, CompactionConcurrencyTest, ConsumerAckTest, ConsumerBatchReceiveTest, CreateSubscriptionTest, GetLastMessageIdCompactedTest, LedgerLostAndSkipNonRecoverableTest, LookupServiceTest, ManagedLedgerConfigTest, MaxProducerTest, MessageListenerExecutorTest, MockMessageTest, MultiTopicsConsumerTest, NegativeAcksTest, PersistentDispatcherMultipleConsumersClassicTest, PersistentDispatcherMultipleConsumersTest, PersistentDispatcherSingleActiveConsumerTest, ProducerBatchSendTest, ProducerConsumerInternalTest, ProducerReconnectionTest, PulsarBrokerStatsClientTest, ServerCnxNonInjectionTest, ServiceUrlProviderTest, SimpleProduceConsumeIoTest, SimpleProducerConsumerDisallowAutoCreateTopicTest, SimpleProducerConsumerMLInitializeDelayTest, SubscriptionStatsTest, TopicSchemaTest
|
@merlimat Please add the following content to your PR description and select a checkbox: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25381 +/- ##
============================================
- Coverage 72.81% 72.70% -0.11%
- Complexity 33791 33879 +88
============================================
Files 1954 1954
Lines 154793 154857 +64
Branches 17731 17740 +9
============================================
- Hits 112716 112596 -120
- Misses 33066 33213 +147
- Partials 9011 9048 +37
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lhotari
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProducerConsumerBasetoSharedPulsarBaseTestAnalyzeBacklogSubscriptionTestconfig leak (subscriptionBacklogScanMaxEntriesnot reset between methods)CompactionConcurrencyTestrace condition assertion (in-memory metadata too fast for concurrent delete race)SimpleProducerConsumerDisallowAutoCreateTopicTesterror message assertion (check exception type instead of message text)Tests not converted (incompatible with shared cluster):
ConnectionHandlerTest—grabCnx()doesn't trigger callback on shared clientPersistentTopicProtectedMethodsTest— backlog quota check timing incompatibleTopicsConsumerImplTest— partition auto-update 60s interval too long for assertionsOrphanPersistentTopicTest— requires Mockito spying on broker serviceConsumerCreationTest—AutoTopicCreationOverrideNPE from config leakProducerCreationTest— hardcodedpublic/defaultnamespace throughoutEnableReplicatedSubscriptionsIsDisabledTest— requiresenableReplicatedSubscriptions=falseSubscriptionPauseOnAckStatPersistTest— manual managed ledger open needs more bookiesDocumentation
doc-not-neededMatching PR in forked repository
PR in forked repository:
Tip
Add the label
ready-to-testto trigger CI