[fix][broker] Change the schema incompatible log from ERROR to WARN level#25483
Merged
Technoboy- merged 2 commits intoapache:masterfrom Apr 8, 2026
Merged
[fix][broker] Change the schema incompatible log from ERROR to WARN level#25483Technoboy- merged 2 commits intoapache:masterfrom
Technoboy- merged 2 commits intoapache:masterfrom
Conversation
utafrali
reviewed
Apr 8, 2026
utafrali
left a comment
utafrali
left a comment
There was a problem hiding this comment.
The two schema-incompatibility-specific log downgrades (lines 461 and 498) are correct and well-motivated. However, the change at line 233 is too broad: the whenComplete on putSchemaIfAbsent catches all failure types, so real server-side errors (storage, ZooKeeper) will now be swallowed at WARN level instead of surfaced as ERROR.
shibd
approved these changes
Apr 8, 2026
poorbarcode
approved these changes
Apr 8, 2026
coderzc
pushed a commit
to coderzc/pulsar
that referenced
this pull request
Apr 15, 2026
…evel (apache#25483) (cherry picked from commit 0b73b3a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Change the schema incompatible log to a warn level, because the client will receive this exception.