[fix][test] Fix flaky PulsarFunctionsJavaThreadTest.testTumblingCountWindowTest#25590
Merged
lhotari merged 5 commits intoapache:masterfrom Apr 28, 2026
Merged
Conversation
…y awaiting async stats and correcting assertions
lhotari
reviewed
Apr 28, 2026
Member
lhotari
left a comment
There was a problem hiding this comment.
minor details in using Awaitility
15 tasks
Contributor
Author
|
@lhotari ! I've removed the redundant Awaitility defaults as suggested and ensured the CI checks are passing |
lhotari
approved these changes
Apr 28, 2026
Member
lhotari
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution @Praveenkumar76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes apache#25391
Motivation
PulsarFunctionsJavaThreadTest.testTumblingCountWindowTestfails intermittently in CI with assertion errors such as:The failure is caused by race conditions in the test. It validates TopicStats and SubscriptionStats immediately after producing messages, while broker statistics are updated asynchronously. As a result, the test may read stale or partially updated values.
Additionally, some assertions use inverted parameter ordering, which makes failure messages harder to interpret.
Modifications
Verifying this change
This change is a bug fix and was verified manually:
Does this pull request potentially affect one of the following parts: