[fix][test] Make NamespacesTest.cleanupAfterMethod tolerant of transient infra failures#25641
Merged
lhotari merged 1 commit intoapache:masterfrom May 1, 2026
Merged
Conversation
…ent infra failures The @AfterMethod cleanup calls admin.namespaces().getNamespaces(tenant); under load (long-running test method, GC pause) the broker's ZK session can expire and that call returns a 500. The actual test method had already passed at that point, so masking the result with a cleanup exception isn't useful. Wrap cleanup in try/catch + warn-log. Subsequent test methods either recover (ZK reconnects) or fail-fast with a clearer error than a session-expired stack trace from a teardown hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
@AfterMethodcleanup callsadmin.namespaces().getNamespaces(tenant). Under load (long-running test method, GC pause) the broker's ZK session can expire and that call returns a 500. The actual test method had already passed at that point, so masking the result with a cleanup exception isn't useful.Wrap the cleanup in try/catch + warn-log. Subsequent test methods either recover (ZK reconnects) or fail-fast with a clearer error than a session-expired stack trace from a teardown hook.
Test plan
testCreateNamespacespasses locally with the change applied