[cleanup] PIP-468: Remove deprecated registerConsumer overloads#25712
Merged
Conversation
ScalableTopicController and ScalableTopicService each carried a 4/5-arg registerConsumer overload that defaulted ScalableConsumerType to STREAM "for backward compatibility". The only production caller (ServerCnx) already passes the explicit type, so the overloads served only stale test code and were leaving deprecation warnings on every broker test compile. Removed both overloads. Updated their only callers — broker tests (ScalableTopicControllerTest and ScalableTopicServiceTest) — to pass ScalableConsumerType.STREAM explicitly. No production behavior change.
merlimat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScalableTopicControllerandScalableTopicServiceeach carried aregisterConsumeroverload that defaultedScalableConsumerTypetoSTREAM"for backward compatibility". The only production caller (ServerCnx) already passes the explicit type, so the overloads served only stale test code and were leaving deprecation warnings on every broker test compile.Removed both overloads. Updated their only callers — broker tests (
ScalableTopicControllerTest,ScalableTopicServiceTest) — to passScalableConsumerType.STREAMexplicitly. No production behavior change.Test plan
pulsar-brokercompile + checkstyle clean.ScalableTopicControllerTest31/31 pass.ScalableTopicServiceTest16/16 pass.[deprecation] registerConsumerwarnings in the broker test compile output.