[fix][broker] Use effective offload policies for extra configs#25781
Open
coderzc wants to merge 4 commits into
Open
[fix][broker] Use effective offload policies for extra configs#25781coderzc wants to merge 4 commits into
coderzc wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#25736 made broker-level
managedLedgerOffloadExtraConfig*entries available toOffloadPoliciesImpl.mergeConfiguration(...). However,managedLedgerExtraConfigurationsdefaults to an empty map, so a namespace or topic offload policy with no extra config still stops fallback to broker-level extra config.This can produce runtime offload policies that inherit the broker driver/bucket/region but lose broker-level extra config such as a tiered-storage bucket prefix. The namespace offloaded-ledger scanner also used raw namespace offload policies directly instead of the effective merged policy used by topic loading.
Modifications
managedLedgerExtraConfigurationsas a map from broker -> namespace -> topic.Verifying this change
./gradlew :pulsar-common:test --tests org.apache.pulsar.common.policies.data.OffloadPoliciesTest./gradlew :pulsar-broker:test --tests org.apache.pulsar.broker.admin.AdminApiOffloadTest.testScanOffloadedLedgersUsesMergedNamespaceOffloadPolicies