Skip to content

[fix][test] Drop racy concurrent-delete assertion in CompactionConcurrencyTest #25827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
merlimat wants to merge 1 commit into from
Closed

[fix][test] Drop racy concurrent-delete assertion in CompactionConcurrencyTest #25827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions .../src/test/java/org/apache/pulsar/broker/service/persistent/CompactionConcurrencyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,25 @@ public void testDisableCompactionConcurrently() throws Exception {
f2.set(admin.topics().deleteSubscriptionAsync(topicName, "__compaction"));
}).start();

// Verify: at least one of the requests should fail (the other may succeed or also fail
// with "not found" if the in-memory metadata store processes them sequentially).
// Verify: both delete requests complete without deadlocking. With the in-memory
// metadata store the deletes can race in any way — both may succeed (the second as a
// no-op when the subscription is already gone), or one may fail with
// SubscriptionBusyException if the broker's concurrency guard catches the overlap.
// We just need to confirm the broker doesn't get stuck and the compaction
// subscription ends up removed.
Awaitility.await().untilAsserted(() -> {
assertTrue(f1.get() != null);
assertTrue(f2.get() != null);
assertTrue(f1.get().isDone());
assertTrue(f2.get().isDone());
assertTrue(f1.get().isCompletedExceptionally() || f2.get().isCompletedExceptionally());
});

// Verify the topic is in a healthy state: the compaction subscription is gone.
PersistentTopic persistentTopic =
(PersistentTopic) getTopic(topicName, false).get().get();
Awaitility.await().untilAsserted(() ->
assertTrue(persistentTopic.getSubscription(Compactor.COMPACTION_SUBSCRIPTION) == null));

// cleanup.
producer.close();
}
Expand Down
Loading