[improve][client] In cases where there is a risk of message loss, adjust the log level to error#25854
Merged
Merged
Conversation
lhotari
approved these changes
May 22, 2026
void-ptr974
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
Background: When calling
consumer.receiveAsync(), the client will maintain a pending completable future that is used to trace the receive messages request. The client will trigger the pending future when the next message comes in.Issue: The client ignores some unexpected cases, which may lose messages.
modifications: print error log if the code runs to an unexpected case
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes