Fix MathUtils ceilDiv integer overflow#25876
Open
hiSandog wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MathUtils.ceilDiv(int, int)negated the dividend before callingMath.floorDiv. ForInteger.MIN_VALUE, that negation overflows and can return the wrong value for positive divisors such as2.Modifications
Compute the quotient and remainder directly, then round up only when the operands have the same sign and there is a non-zero remainder. Added coverage for negative operands and
Integer.MIN_VALUEboundaries.Verifications
git diff --check./gradlew :pulsar-client:test --tests org.apache.pulsar.client.util.MathUtilsTest(did not start locally: no Java Runtime is installed in this environment)