[fix][client] Fix incorrect topic in OTel spans for partitioned producers#25896
Open
void-ptr974 wants to merge 1 commit into
Open
[fix][client] Fix incorrect topic in OTel spans for partitioned producers#25896void-ptr974 wants to merge 1 commit into
void-ptr974 wants to merge 1 commit into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25897
Motivation
The OTel producer interceptor cached the topic from the first producer it processed.
For partitioned producers, the same interceptor can be used by multiple internal partition producers. For example, if the first message is sent to:
persistent://public/default/my-topic-partition-0the interceptor caches that topic. If a later message is sent to:
persistent://public/default/my-topic-partition-1the producer span could still be created as:
send persistent://public/default/my-topic-partition-0and
messaging.destination.namecould also be reported as:persistent://public/default/my-topic-partition-0This makes OTel producer spans report an incorrect topic for messages sent to other partitions.
Modifications
Use the current producer topic when creating each OTel producer span instead of caching the first topic.
Verifying this change
This change added tests and can be verified as follows:
./gradlew :pulsar-client-original:compileJava./gradlew :pulsar-broker:test --tests org.apache.pulsar.broker.service.OpenTelemetryTracingIntegrationTest.testPartitionedProducerSpanUsesCurrentProducerTopicDoes this pull request potentially affect one of the following parts: